Skip to content

Distributed Background Jobs: Catch exceptions in job loop to improve application resilience #21099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyButland merged 4 commits into from
Dec 16, 2025
Merged

Distributed Background Jobs: Catch exceptions in job loop to improve application resilience #21099

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae1591d
Set exit code when exception is thrown
nikolajlauridsen Dec 9, 2025
b649ec7
Merge branch 'main' into v17/fix/stop-background-job-correctly
nikolajlauridsen Dec 10, 2025
f58e211
Catch any error instead so we don't stop the application
nikolajlauridsen Dec 10, 2025
d0857ac
Handle exception when ensuring jobs
nikolajlauridsen Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Umbraco.Infrastructure/BackgroundJobs/DistributedBackgroundJobHostedService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System.Diagnostics;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using Umbraco.Cms.Core;
Expand All @@ -22,10 +21,6 @@ public class DistributedBackgroundJobHostedService : BackgroundService
/// <summary>
/// Initializes a new instance of the <see cref="DistributedBackgroundJobHostedService"/> class.
/// </summary>
/// <param name="logger"></param>
/// <param name="runtimeState"></param>
/// <param name="distributedJobService"></param>
/// <param name="distributedJobSettings"></param>
public DistributedBackgroundJobHostedService(
ILogger<DistributedBackgroundJobHostedService> logger,
IRuntimeState runtimeState,
Expand Down Expand Up @@ -68,6 +63,13 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
{
_logger.LogInformation("Timed Hosted Service is stopping.");
}
catch (Exception)
{
// Ensure that the app doesn't shut down gracefully so that environments like Kubernetes can restart it
// See https://github.com/dotnet/runtime/issues/67146 for more information.
Environment.ExitCode = 1;
throw;
}
}

private async Task RunRunnableJob()
Expand Down
Loading