QA Added unit tests for HideBackOfficeTokensHandler#21067
Merged
Conversation
The __Host- cookie prefix enforces secure cookies at browser level, which caused cookies to be rejected when running over HTTP in local development environments even when UseHttps was set to false. Cookie names are now calculated per-request based on both the UseHttps setting and whether the current request is over HTTPS, matching the logic used for the Secure cookie option.
kjac
reviewed
Dec 5, 2025
...sts.UnitTests/Umbraco.Cms.Api.Common/DependencyInjection/HideBackOfficeTokensHandlerTests.cs
Outdated
Show resolved
Hide resolved
kjac
reviewed
Dec 5, 2025
...sts.UnitTests/Umbraco.Cms.Api.Common/DependencyInjection/HideBackOfficeTokensHandlerTests.cs
Show resolved
Hide resolved
Contributor
|
PR looks good. I left a few comments 😄 I'll refrain from approving until the first PR has been merged and has found its way into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for all the main handler methods in HideBackOfficeTokensHandler including the cookieprefix permutations introduced in #21056.
This pr is based on #21056 and should be merged in after that one to keep things tidy.