Skip to content

Conversation

@iOvergaard
Copy link
Contributor

This pull request updates the log viewer translations across multiple languages to improve consistency, reduce duplication, and support dynamic polling intervals. It removes several redundant or unused log-related strings and introduces parameterized functions for polling intervals in all supported languages. Additionally, the English and Danish translations receive several new log viewer UI strings for enhanced user experience.

Translation cleanup and consistency:

  • Removed redundant or unused log viewer strings such as filterSearch, totalItems, exception, properties, and various "find logs with..." and "open" entries from all affected language files. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Polling interval improvements:

  • Replaced multiple hardcoded polling interval strings (e.g., "Every 2 seconds", "Polling every 2s") with parameterized functions (pollingInterval and pollingActive) in all languages, allowing dynamic display of polling intervals. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Enhancements to English and Danish translations:

  • Added new log viewer UI strings for features like no results, sorting, loading, searching, error messages, and log statistics in both en.ts and da.ts. [1] [2]

Streamlining and modernization:

  • Simplified and modernized the translation files by removing duplicated or overly specific strings and relying more on parameterized entries for flexibility and maintainability. (All references above)

Improved user experience:

  • These changes enable a more consistent and dynamic log viewer interface across all supported languages, making it easier to add or adjust polling intervals and related UI elements in the future. (All references above)

Copilot AI review requested due to automatic review settings November 21, 2025 11:07
@iOvergaard iOvergaard added type/bug area/frontend preview/backoffice Pull requests that can be previewed in a static version of the Backoffice release/17.1.0 labels Nov 21, 2025
Copilot finished reviewing on behalf of iOvergaard November 21, 2025 11:10
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-ground-017b08103-20923.westeurope.6.azurestaticapps.net

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request modernizes the log viewer localization by replacing hardcoded strings with proper localization keys and introducing parameterized functions for dynamic polling intervals. The changes remove redundant translation keys across all 15 supported languages while adding comprehensive new UI strings to English and Danish translations.

Key Changes:

  • Replaces all hardcoded UI strings in log viewer components with localized terms
  • Introduces parameterized pollingInterval and pollingActive functions for dynamic polling display
  • Removes 11-17 unused/redundant translation keys from each language file
  • Adds 29 new translation keys to English and Danish for enhanced log viewer UI

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
log-viewer-search-input.element.ts Localizes search input labels, placeholders, and button text
log-viewer-search-input-modal.element.ts Localizes save search dialog with proper labels and buttons
log-viewer-polling-button.element.ts Implements dynamic polling interval display using parameterized functions
log-viewer-messages-list.element.ts Localizes table headers, empty states, and loading messages
log-viewer-message.element.ts Converts search menu to use localized labels and converts static array to method
log-viewer-log-level-filter-menu.element.ts Localizes log level filter options and labels
log-overview-view.element.ts Localizes overview section headings
log-viewer-saved-searches-overview.element.ts Localizes saved searches section and "All logs" label
log-viewer-message-templates-overview.element.ts Localizes message templates heading and count display
log-viewer-log-types-chart.element.ts Localizes chart heading and description
log-viewer-too-many-logs-warning.element.ts Localizes warning messages and changes base class to UmbLitElement
log-viewer-date-range-selector.element.ts Localizes date range labels
en.ts Removes 11 unused keys and adds 29 new log viewer UI strings
da.ts Removes 16 unused keys, adds 29 new strings, and fixes whitespace
vi.ts Removes 16 unused keys and adds polling interval functions
tr.ts Removes 7 unused keys (missing polling functions)
pt.ts Removes 16 unused keys and adds polling interval functions
nl.ts Removes 16 unused keys and adds polling interval functions
it.ts Removes 16 unused keys and adds polling interval functions
hr.ts Removes 16 unused keys and adds polling interval functions
fr.ts Removes 7 unused keys (missing polling functions)
cy.ts Removes 16 unused keys and adds polling interval functions
cs.ts Removes 7 unused keys (missing polling functions)
bs.ts Removes 16 unused keys and adds polling interval functions
ar.ts Removes 16 unused keys and adds polling interval functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/frontend category/localization preview/backoffice Pull requests that can be previewed in a static version of the Backoffice release/17.1.0 type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants