Fixes broken integration test for v17 release#20582
Merged
kjac merged 2 commits intorelease/17.0from Oct 21, 2025
Merged
Conversation
nikolajlauridsen
added
the
release/no-notes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken integration tests in the V17 release by updating the test setup code to accommodate a breaking change in the PublishAsync method's API signature, replacing the deprecated CultureAndScheduleModel with ICollection<CulturePublishScheduleModel>.
Key Changes:
- Updated the
CultureAndScheduleproperty type fromCultureAndScheduleModeltoICollection<CulturePublishScheduleModel> - Simplified the culture and schedule initialization using collection expression syntax
- Removed the now-unused
ContentScheduleproperty
kjac
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new integration tests in #20554 are broken in V17 due to a breaking change in the PublishAsync method, this PR updates the integration tests to use
ICollection<CulturePublishScheduleModel>instead ofCultureAndScheduleModel