Grid (Legacy): Fix for RTE drag and drop issue (closes #16591)#20498
Conversation
|
Hi there @bhcoder, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
Nice, thanks very much for this contribution @bhcoder. I've tested locally and can confirm this resolves the issue that I could replicate before applying this update.
Head branch was pushed to by a user without write access
Fixed #16591
The issue is caused by the upgrade of TinyMCE to v6:
editorsproperty is deprecated in TinyMCE 4.7 and removed in TinyMCE 6.0 - Usetinymce.get()insteadeditor.settingsto reuse the settings once the RTE is reinitialized after drag and drop