Micro-optimization: Move compilation of some Regex generation to compile time instead of runtime, make some static ones compiled#20287
Conversation
…runtime, make some static ones compiled
|
Hi there @Henr1k80, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
AndyButland
left a comment
There was a problem hiding this comment.
All looks fine to me, thanks for the contribution @Henr1k80.
Prerequisites
Description
This is not in any hot code path, this is just a little prep to possibly have all
Regexgenerated at compile time instead of at runtime.If all runtime regex generation is removed, the regex generation code is never needed at runtime, only at compile time.
This results in faster startup, as less IL ASM needs to be compiled