Skip to content

UX: Add slightly more padding at top so user card outline is not cutoff#20258

Merged
georgebid merged 1 commit intoumbraco:mainfrom
bjarnef:v16/bugfix/card-outline-user-grid
Sep 25, 2025
Merged

UX: Add slightly more padding at top so user card outline is not cutoff#20258
georgebid merged 1 commit intoumbraco:mainfrom
bjarnef:v16/bugfix/card-outline-user-grid

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 24, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

As the title says :)

Before

image

After

image

Copilot AI review requested due to automatic review settings September 24, 2025 18:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a visual issue where the user card outline was being cut off due to insufficient top padding. The change increases the top padding when the header is transparent to provide more visual clearance.

Key Changes

  • Increased top padding from var(--uui-size-space-1) to var(--uui-size-space-2) in the body layout element

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Nice one 😄 Merged!

@georgebid georgebid merged commit 149b191 into umbraco:main Sep 25, 2025
28 checks passed
@bjarnef bjarnef deleted the v16/bugfix/card-outline-user-grid branch September 25, 2025 12:36
@AndyButland AndyButland changed the title Add slightly more padding at top so user card outline is not cutoff UX: Add slightly more padding at top so user card outline is not cutoff Sep 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants