UX: Make approved colour picker remove button consistent with other multi value item remove buttons#20257
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the visual styling of the remove button in the color picker configuration to maintain consistency with other multi-value item remove buttons across the CMS interface.
- Updates the
lookproperty from "primary" to "outline" for the delete button in color picker items
|
Hi there @bjarnef, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
There was a problem hiding this comment.
Looks good, thanks @bjarnef. Buttons are displaying with the expected colours now.
Given we've built 16.3 for internal testing now, this will go into 16.4, so I'll merge and tag it with that release.
Prerequisites
If there's an existing issue for this PR then this fixes #20167
Description
Make remove button in configuration of (approved) color picker consistent with other datatype configuration.