Skip to content

UX: Make approved colour picker remove button consistent with other multi value item remove buttons#20257

Merged
AndyButland merged 1 commit intoumbraco:mainfrom
bjarnef:v16/bugfix/20167-multi-item-input-remove-button
Sep 24, 2025
Merged

UX: Make approved colour picker remove button consistent with other multi value item remove buttons#20257
AndyButland merged 1 commit intoumbraco:mainfrom
bjarnef:v16/bugfix/20167-multi-item-input-remove-button

Conversation

@bjarnef
Copy link
Contributor

@bjarnef bjarnef commented Sep 24, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #20167

Description

Make remove button in configuration of (approved) color picker consistent with other datatype configuration.

image

Copilot AI review requested due to automatic review settings September 24, 2025 18:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the visual styling of the remove button in the color picker configuration to maintain consistency with other multi-value item remove buttons across the CMS interface.

  • Updates the look property from "primary" to "outline" for the delete button in color picker items

@github-actions
Copy link

Hi there @bjarnef, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bjarnef. Buttons are displaying with the expected colours now.

Given we've built 16.3 for internal testing now, this will go into 16.4, so I'll merge and tag it with that release.

@AndyButland AndyButland merged commit e938027 into umbraco:main Sep 24, 2025
28 checks passed
@AndyButland AndyButland changed the title Make remove button consistent with other multi value item remove button UX: Make approved colour picker remove button consistent with other multi value item remove buttons Sep 24, 2025
@bjarnef bjarnef deleted the v16/bugfix/20167-multi-item-input-remove-button branch September 24, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent remove button style in multiple values configurations

3 participants