Add more icons correct Content Type Designer Icons#20252
Merged
leekelleher merged 2 commits intomainfrom Sep 24, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new icons to the icon registry and updates the Content Type Designer to use more semantically appropriate icons for different property states.
- Adds two new Lucide icons:
trending-up-downandstretch-horizontal - Updates existing heading icons to remove duplicate class names
- Replaces generic icons with more specific ones in the Content Type Designer interface
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| icon-trending-up-down.ts | Adds new trending-up-down icon for invariant properties |
| icon-stretch-horizontal.ts | Adds new stretch-horizontal icon for label-on-top layout |
| icon-heading.ts | Removes duplicate CSS class from heading icon |
| icon-heading-6.ts | Removes duplicate CSS class from heading-6 icon |
| icon-heading-5.ts | Removes duplicate CSS class from heading-5 icon |
| icons.ts | Registers the two new icons in the icon registry |
| icon-dictionary.json | Maps new icons to their SVG source files |
| content-type-design-editor-property.element.ts | Updates Content Type Designer to use new semantic icons |
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-heading.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-heading-6.ts
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/icon-registry/icons/icon-heading-5.ts
Show resolved
Hide resolved
leekelleher
approved these changes
Sep 24, 2025
This was referenced Jan 26, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding more icons and adjusting the shared icon in Content Type Designer