Login: Added custom validation for missing password and user/email on the login form #20233
CodeScene PR Check
Quality Gate Failed
(1 files improve in Code Health)
Gates Failed
(1 file with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| login.page.element.ts | 1 advisory rule | 9.66 → 9.61 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| auth.element.ts | 9.37 → 9.61 | Complex Method |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method login.page.element.ts: UmbLoginPageElement.handleSubmit
✅ Improving Code Health:
- Complex Method auth.element.ts: UmbAuthElement.disconnectedCallback
Annotations
Check notice on line 266 in src/Umbraco.Web.UI.Login/src/auth.element.ts
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ No longer an issue: Complex Method
UmbAuthElement.disconnectedCallback is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 121 in src/Umbraco.Web.UI.Login/src/components/pages/login.page.element.ts
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Complex Method
UmbLoginPageElement.handleSubmit increases in cyclomatic complexity from 12 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.