Conversation
…tion are removed from the value, such that they will be removed from the persisted data when saved.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where checkbox list property editors retain values that are no longer available in the configuration options. When a checkbox list's predefined values are updated (e.g., removing an option), previously selected values that are no longer valid continue to persist in the content, even after republishing.
- Adds validation to filter out invalid values from the model when the checkbox list controller initializes
- Ensures that when content is saved, only currently valid configuration options are persisted
- Provides a clean solution for v13 that automatically removes orphaned values without requiring manual intervention
src/Umbraco.Web.UI.Client/src/views/propertyeditors/checkboxlist/checkboxlist.controller.js
Show resolved
Hide resolved
kjac
approved these changes
Sep 22, 2025
Contributor
kjac
left a comment
There was a problem hiding this comment.
Works as advertised 👍
For good measure I also tested the dropdown in multi-select config, and that works as-is, so no need to apply a similar fix here.
This was referenced Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Brought to attention from Umbraco support case.
Description
I've verified I can replicate the problem via:
So basically once a value is allowed for selection and selected, you can't remove it.
I've resolved it in this PR by, on the client, when initialising the checkbox list property editor, removing any values from the model that are no longer valid according to the configuration. With that done, when the document is saved, the no longer valid values are removed.
Maybe this isn't how we'd want to handle it in the latest version, where we try not to silently modify values and rather given the editor the option to see and explicitly remove the no longer valid value - for 13 I think this is a reasonable approach, it requires much less effort on the client-side. And otherwise you are a bit stuck, short of modifying values in the database tables.