Segments: Auto unfold the culture variant in non-culture-variant mode#20189
Merged
nielslyngsoe merged 4 commits intomainfrom Oct 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements automatic unfolding of culture variants in the segment-only variant scenario for documents. When a workspace varies by segments but not by culture, the first culture variant is automatically expanded to show all segments upfront in the split-view variant selector.
- Adds logic to automatically expand culture variants when only segment variants exist
- Refactors element name usage to be more consistent
- Improves variable naming for better clarity
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| document-workspace-split-view-variant-selector.element.ts | Removes unnecessary elementName variable and inlines the custom element name |
| workspace-split-view-variant-selector.element.ts | Adds auto-expansion logic for segment-only scenarios and improves variable naming |
...e/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts
Outdated
Show resolved
Hide resolved
...e/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts
Outdated
Show resolved
Hide resolved
…ts/workspace-split-view/workspace-split-view-variant-selector.element.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t-option # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts
iOvergaard
approved these changes
Oct 2, 2025
nielslyngsoe
deleted the
v16/feature/auto-unfold-first-culture-variant-option
branch
This was referenced Jan 26, 2026
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Segment only variant scenario then unfold the Culture Variant, so we can see all the segments up front:
