Dependencies: Updates to .NET 10 RC and NPoco 6.1 #20184
CodeScene PR Check
Quality Gate Failed
(2 files improve in Code Health)
Gates Failed
(2 files with Complex Method, Large Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| TrackedReferencesRepository.cs | 1 advisory rule | 7.47 → 7.17 | Suppress |
| ContentTypeCommonRepository.cs | 1 advisory rule | 6.92 → 6.84 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| TestDatabase.cs | no change | Primitive Obsession |
| ContentService.cs | 2.34 → 2.39 | Code Duplication |
| BackOfficeUserStore.cs | 4.23 → 4.34 | Code Duplication |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method ContentTypeCommonRepository.cs: MapGroupsAndProperties
- Large Method TrackedReferencesRepository.cs: GetPagedDescendantsInReferences
- Large Method TrackedReferencesRepository.cs: GetPagedRelations
- Complex Method ContentTypeCommonRepository.cs: GetAllTypesInternal
- Complex Method ContentTypeCommonRepository.cs: MapTemplates
✅ Improving Code Health:
- Code Duplication ContentService.cs: GetPagedOfTypes 🔥
- Code Duplication BackOfficeUserStore.cs
- Primitive Obsession TestDatabase.cs
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
❌ Getting worse: Complex Method
MapGroupsAndProperties increases in cyclomatic complexity from 16 to 17, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
❌ Getting worse: Complex Method
GetAllTypesInternal increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
❌ Getting worse: Complex Method
MapTemplates increases in cyclomatic complexity from 9 to 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
❌ Getting worse: Large Method
GetPagedDescendantsInReferences increases from 76 to 81 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
❌ New issue: Large Method
GetPagedRelations has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in tests/Umbraco.Tests.Common/TestHelpers/TestDatabase.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 60.00% to 50.50%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in src/Umbraco.Core/Services/ContentService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ Getting better: Code Duplication
reduced similar code in: GetPagedOfTypes. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Check notice on line 1 in src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v17/dev)
✅ Getting better: Code Duplication
reduced similar code in: GetUsersAsync,GetUsersAsync. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.