Skip to content

Accessibility changes for the top navbar tabs and settings tabs #20107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madsrasmussen merged 3 commits into from
Sep 22, 2025
Merged

Accessibility changes for the top navbar tabs and settings tabs #20107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c401933
Accessibility changes for the top navbar tabs and settings tabs
Abdjulaziz Sep 9, 2025
48de753
Merge branch 'main' into v16/task/55255-add-accessible-name-to-sectio…
madsrasmussen Sep 22, 2025
2a45426
fix indention
madsrasmussen Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions ...mbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-header-sections.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ export class UmbBackofficeHeaderSectionsElement extends UmbLitElement {
);
}

#getSectionName(section: UmbExtensionManifestInitializer<ManifestSection>) {
return section.manifest?.meta.label ? this.localize.string(section.manifest?.meta.label) : section.manifest?.name;
}

#getSectionPath(manifest: ManifestSection | undefined) {
return `section/${manifest?.meta.pathname}`;
}
Expand Down Expand Up @@ -108,12 +112,10 @@ export class UmbBackofficeHeaderSectionsElement extends UmbLitElement {
?active="${this._currentSectionAlias === section.alias}"
@click=${(event: PointerEvent) => this.#onSectionClick(event, section.manifest)}
href="${this.#getSectionPath(section.manifest)}"
label="${ifDefined(
section.manifest?.meta.label
? this.localize.string(section.manifest?.meta.label)
: section.manifest?.name,
)}"
data-mark="section-link:${section.alias}"></uui-tab>
label="${ifDefined(this.#getSectionName(section))}"
data-mark="section-link:${section.alias}"
>${this.#getSectionName(section)}</uui-tab
>
`,
)}
</uui-tab-group>
Expand Down
12 changes: 8 additions & 4 deletions ....Web.UI.Client/src/packages/core/section/section-main-views/section-main-views.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ export class UmbSectionMainViewElement extends UmbLitElement {
: nothing;
}

#getDashboardName(dashboard: ManifestDashboard) {
return dashboard.meta?.label ? this.localize.string(dashboard.meta.label) : (dashboard.name ?? dashboard.alias);
}

#renderDashboards() {
// Only show dashboards if there are more than one dashboard or if there are both dashboards and views
return (this._dashboards.length > 0 && this._views.length > 0) || this._dashboards.length > 1
Expand All @@ -124,10 +128,10 @@ export class UmbSectionMainViewElement extends UmbLitElement {
return html`
<uui-tab
href="${this._routerPath}/${dashboardPath}"
label="${dashboard.meta.label
? this.localize.string(dashboard.meta.label)
: (dashboard.name ?? dashboard.alias)}"
?active="${isActive}"></uui-tab>
label="${this.#getDashboardName(dashboard)}"
?active="${isActive}"
>${this.#getDashboardName(dashboard)}</uui-tab
>
`;
})}
</uui-tab-group>
Expand Down
Loading