Umbraco Engage UmbracoUrlAlias Fix - Fixes #19654 (#19827)#19850
Merged
AndyButland merged 1 commit intomainfrom Aug 4, 2025
Merged
Conversation
* Fixes #19654 Adds the propertyAlias to the VariationContext so that products implementing the GetSegment method are aware which propertyAlias it's being called for * Re-implement original variation context for backwards compatibility * Fixes hidden overload method Ensures the `GetSegment` method overload is not hidden when a null `propertyAlias` is passed. * Resolve backward compatibility issues. * Improved comments. --------- Co-authored-by: Andy Butland <[email protected]> # Conflicts: # src/Umbraco.PublishedCache.NuCache/Property.cs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for property alias to the variation context system to address issues with Umbraco Engage UmbracoUrlAlias functionality. The changes enhance the existing variation context methods to accept and utilize property alias information for more granular segment handling.
- Enhanced
VariationContextandVariationContextAccessorto support property alias parameter - Updated all property value retrieval methods to pass property alias to variation context
- Added backward compatibility through method overloads with obsolete markers
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PublishedProperty.cs | Stores property type alias and passes it to all ContextualizeVariation calls |
| VariationContextAccessorExtensions.cs | Adds new method overloads with property alias parameter and marks old ones obsolete |
| VariationContext.cs | Adds virtual GetSegment method that accepts property alias parameter |
| PublishedValueFallback.cs | Updates all ContextualizeVariation calls to include property alias parameter |
src/Umbraco.Core/Models/PublishedContent/VariationContextAccessorExtensions.cs
Show resolved
Hide resolved
Contributor
|
Hi @AndyButland, It was a bit difficult to test haha, but these changes work in Engage V16 as well (just like V13!). |
cornehoskam
approved these changes
Aug 4, 2025
Contributor
Author
|
Great, thanks for checking. |
AndyButland
deleted the
v16/bugfix/make-variation-context-aware-of-property-alias
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an Umbraco 16 cherry-pick update of #19827 addressing #19654
@cornehoskam - would you be in a position to test this with Engage 16, to verify that the situation is resolved here too please?