Skip to content

Provides an abstraction for creating the JavaScriptEncoder used in SystemTextConfigurationEditorJsonSerializer #19849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikolajlauridsen merged 4 commits into from
Aug 7, 2025

Removed name parameter and used a generic type instead.

7113af0
Select commit
Loading
Failed to load commit list.
Merged

Provides an abstraction for creating the JavaScriptEncoder used in SystemTextConfigurationEditorJsonSerializer #19849

Removed name parameter and used a generic type instead.
7113af0
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 7, 2025 in 54s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (1 file with Large Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
UmbracoBuilder.CoreServices.cs 1 advisory rule 8.85 → 8.85 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method UmbracoBuilder.CoreServices.cs: AddCoreInitialServices

✅ Improving Code Health:

  • Code Duplication OutputExpansionStrategyTestBase.cs

Annotations

Check warning on line 127 in src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

AddCoreInitialServices increases from 119 to 120 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in tests/Umbraco.Tests.UnitTests/Umbraco.Core/DeliveryApi/OutputExpansionStrategyTestBase.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Code Duplication 

reduced similar code in: CreateMediaPicker3Property,CreateMediaPickerProperty. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis