Section Sidebar Menu Expansion #19810
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Aug 12, 2025 in 1m 1s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(4 files with Complex Method, Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| extension-slot.element.ts | 1 advisory rule | 10.00 → 9.39 | Suppress |
| tree-menu-item.element.ts | 1 advisory rule | 10.00 → 9.69 | Suppress |
| menu-variant-tree-structure-workspace-context-base.ts | 1 advisory rule | 9.55 → 9.45 | Suppress |
| menu-tree-structure-workspace-context-base.ts | 1 advisory rule | 9.50 → 9.39 | Suppress |
Absence of Expected Change Pattern
- Umbraco-CMS/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/ScriptFolder.spec.ts is usually changed with: Umbraco-CMS/tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Settings/Script/Script.spec.ts
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication extension-slot.element.ts
- Complex Method menu-tree-structure-workspace-context-base.ts: UmbMenuTreeStructureWorkspaceContextBase.requestStructure
- Complex Method menu-variant-tree-structure-workspace-context-base.ts: UmbMenuVariantTreeStructureWorkspaceContextBase.requestStructure
- Complex Method tree-menu-item.element.ts: UmbMenuItemTreeDefaultElement.onExpansionChange
✅ Improving Code Health:
- Complex Method default-section.element.ts: UmbSectionDefaultElement.observeRoutes
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
UmbSectionDefaultElement.observeRoutes is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
UmbMenuItemTreeDefaultElement.onExpansionChange has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
UmbMenuTreeStructureWorkspaceContextBase.requestStructure increases in cyclomatic complexity from 18 to 22, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
UmbMenuVariantTreeStructureWorkspaceContextBase.requestStructure increases in cyclomatic complexity from 16 to 20, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Code Duplication
The module contains 2 functions with similar structure: UmbExtensionSlotElement.addEventListenersToExtensionElement,UmbExtensionSlotElement.removeEventListenersFromExtensionElement. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading