Skip to content

UFM: Code tidy-up #19687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOvergaard merged 8 commits into from
Jul 8, 2025

Added "ufm-" prefix to eslint local rules

068d053
Select commit
Loading
Failed to load commit list.
Merged

UFM: Code tidy-up #19687

Added "ufm-" prefix to eslint local rules
068d053
Select commit
Loading
Failed to load commit list.
Azure Pipelines / Umbraco CMS 9+ failed Jul 8, 2025 in 34m 56s

Build #16.1.0--rc.preview.143+176f9da had test failures

3 errors / 29,325 warnings

Details

Tests

  • Failed: 1 (0.01%)
  • Passed: 14,629 (99.49%)
  • Other: 74 (0.50%)
  • Total: 14,704

Annotations

Check failure on line 13 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

Build log #L13 

Error: The process '/Users/runner/hostedtoolcache/dotnet/dotnet' failed with exit code 131

Check failure on line 17 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

Build log #L17 

Dotnet command failed with non-zero exit code on the following projects : [
  '/Users/runner/work/1/s/tests/Umbraco.Tests.Integration/Umbraco.Tests.Integration.csproj'
]

Check failure on line 260 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

Build log #L260 

PowerShell exited with code '1'.

Check failure on line 1 in can create content with the custom image cropper data type

See this annotation in the file changed.

@azure-pipelines azure-pipelines / Umbraco CMS 9+

can create content with the custom image cropper data type 

ContentWithImageCropper.spec.ts:76:5 can create content with the custom image cropper data type
Raw output 
  [chromium] › DefaultConfig\Content\ContentWithImageCropper.spec.ts:76:5 › can create content with the custom image cropper data type @smoke 

    TypeError: Cannot read properties of undefined (reading 'alias')

      94 |   expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy();
      95 |   const contentData = await umbracoApi.document.getByName(contentName);
    > 96 |   expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName));
         |                                ^
      97 |   expect(contentData.values[0].value.src).toContain(AliasHelper.toAlias(imageFileName));
      98 |   expect(contentData.values[0].value.focalPoint).toEqual(defaultFocalPoint);
      99 |   expect(contentData.values[0].value.crops[0].alias).toEqual(AliasHelper.toAlias(cropAlias));
        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\Content\ContentWithImageCropper.spec.ts:96:32

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-Content-Cont-0c695-tom-image-cropper-data-type-chromium\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-Content-Cont-0c695-tom-image-cropper-data-type-chromium\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────

    TypeError: Cannot read properties of undefined (reading 'alias')

      94 |   expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy();
      95 |   const contentData = await umbracoApi.document.getByName(contentName);
    > 96 |   expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName));
         |                                ^
      97 |   expect(contentData.values[0].value.src).toContain(AliasHelper.toAlias(imageFileName));
      98 |   expect(contentData.values[0].value.focalPoint).toEqual(defaultFocalPoint);
      99 |   expect(contentData.values[0].value.crops[0].alias).toEqual(AliasHelper.toAlias(cropAlias));
        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\Content\ContentWithImageCropper.spec.ts:96:32

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-Content-Cont-0c695-tom-image-cropper-data-type-chromium-retry1\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-Content-Cont-0c695-tom-image-cropper-data-type-chromium-retry1\trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────

    TypeError: Cannot read properties of undefined (reading 'alias')

      94 |   expect(await umbracoApi.document.doesNameExist(contentName)).toBeTruthy();
      95 |   const contentData = await umbracoApi.document.getByName(contentName);
    > 96 |   expect(contentData.values[0].alias).toEqual(AliasHelper.toAlias(customDataTypeName));
         |                                ^
      97 |   expect(contentData.values[0].value.src).toContain(AliasHelper.toAlias(imageFileName));
      98 |   expect(contentData.values[0].value.focalPoint).toEqual(defaultFocalPoint);
      99 |   expect(contentData.values[0].value.crops[0].alias).toEqual(AliasHelper.toAlias(cropAlias));
        at D:\a\1\s\tests\Umbraco.Tests.AcceptanceTest\tests\DefaultConfig\Content\ContentWithImageCropper.spec.ts:96:32

    attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
    results\DefaultConfig-Content-Cont-0c695-tom-image-cropper-data-type-chromium-retry2\trace.zip
    Usage:

        npx playwright show-trace results\DefaultConfig-Content-Cont-0c695-tom-image-cropper-data-type-chromium-retry2\trace.zip

    ───────────────────────────────────
View more details on Azure Pipelines