-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Label property-editor, adds UFM template support #19610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d2b7abe
Adds `labelTemplate` config to Label editor
leekelleher 1e091b7
Code tidyup for Label editor element
leekelleher 0dead53
Adds "format-bytes" UFM filter
leekelleher e6c4acb
Renamed "format-bytes" to "bytes"
leekelleher 0a55030
Label element tidy-up + copilot amends
leekelleher 29174cd
Added `formatBytes` options
leekelleher a9f9b72
Simplified condition, thanks CodeScene
leekelleher c419342
Reverted element export
leekelleher b05cbb4
Merge branch 'main' into v16/feature/label-editor-ufm
leekelleher 93601fd
Merge branch 'main' into v16/feature/label-editor-ufm
madsrasmussen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 16 additions & 10 deletions
26
...aco.Web.UI.Client/src/packages/property-editors/label/property-editor-ui-label.element.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
src/Umbraco.Web.UI.Client/src/packages/ufm/filters/bytes.filter.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { UmbUfmFilterBase } from './base.filter.js'; | ||
| import { formatBytes } from '@umbraco-cms/backoffice/utils'; | ||
|
|
||
| class UmbUfmBytesFilterApi extends UmbUfmFilterBase { | ||
| filter(str?: string, decimals?: number, kilo?: number, culture?: string): string { | ||
| if (!str?.length) return ''; | ||
| return formatBytes(Number(str), { decimals, kilo, culture }); | ||
| } | ||
| } | ||
|
|
||
| export { UmbUfmBytesFilterApi as api }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.