Tiptap RTE: A11Y label improvements#19531
Merged
iOvergaard merged 5 commits intomainfrom Jun 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances accessibility by adding label attributes to inputs, buttons, and selects across the Tiptap RTE toolbar, statusbar, menu components, and the overlay-size editor.
- Adds
labelto the filter input and toolbar buttons in the toolbar configuration. - Mirrors these changes in the statusbar configuration.
- Updates the toolbar menu and button elements to bind labels directly.
- Introduces a
labelon the overlay-size select component.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/.../tiptap/property-editors/.../toolbar-configuration.element.ts | Added label attributes to filter input and toolbar item buttons. |
| src/.../tiptap/property-editors/.../statusbar-configuration.element.ts | Added label attributes to filter input and statusbar item buttons. |
| src/.../tiptap/components/toolbar/tiptap-toolbar-menu.element.ts | Removed ifDefined and bound label directly on menu buttons. |
| src/.../tiptap/components/toolbar/tiptap-toolbar-button.element.ts | Removed ifDefined and replaced with a direct label binding. |
| src/.../overlay-size/property-editor-ui-overlay-size.element.ts | Added a label to the overlay-size <uui-select>. |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/toolbar/tiptap-toolbar-menu.element.ts:7
- Removing
ifDefinedmay cause thelabelattribute to render as "undefined" when its value is missing. Consider usingifDefined(label)or providing a default string to avoid invalid attribute values.
import { css, customElement, html, state, when } from '@umbraco-cms/backoffice/external/lit';
src/Umbraco.Web.UI.Client/src/packages/tiptap/components/toolbar/tiptap-toolbar-button.element.ts:46
- The variable
labelis not defined here after replacingifDefined. You should either declareconst label = this.manifest?.meta.labelor revert to usingthis.manifest?.meta.labelwrapped withifDefinedto prevent a ReferenceError.
label=${label}
iOvergaard
approved these changes
Jun 27, 2025
This was referenced Jul 28, 2025
This was referenced Aug 26, 2025
This was referenced Sep 8, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds labels to various actions, buttons and menus in the Tiptap RTE and associated property-editors (for toolbar, statusbar, etc).