Skip to content

Resolved exception thrown from NuCache locking mechanism on near-simultaneous content publish requests #19434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Migaroez merged 2 commits into from
May 28, 2025
Merged

Resolved exception thrown from NuCache locking mechanism on near-simultaneous content publish requests #19434

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35f70e
Removed the check before the wait that threw the recursive lock excep…
AndyButland May 27, 2025
ca024e8
Removed unnecessary check on releasing the lock.
AndyButland May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/Umbraco.PublishedCache.NuCache/ContentStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Collections.Concurrent;

Check notice on line 1 in src/Umbraco.PublishedCache.NuCache/ContentStore.cs

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ Getting better: Lines of Code in a Single File 

The lines of code decreases from 1189 to 1185, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in src/Umbraco.PublishedCache.NuCache/ContentStore.cs

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ Getting better: Overall Code Complexity 

The mean cyclomatic complexity decreases from 4.38 to 4.37, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
using System.Diagnostics.CodeAnalysis;
using CSharpTest.Net.Collections;
using Microsoft.Extensions.Logging;
Expand Down Expand Up @@ -321,17 +321,12 @@
{
if (_writeLock.CurrentCount != 0)
{
throw new InvalidOperationException("Write lock must be acquried.");
throw new InvalidOperationException("Write lock must be acquired.");
}
}

private void Lock(WriteLockInfo lockInfo, bool forceGen = false)
{
if (_writeLock.CurrentCount == 0)
{
throw new InvalidOperationException("Recursive locks not allowed");
}

if (_writeLock.Wait(_monitorTimeout))
{
lockInfo.Taken = true;
Expand Down
Loading