Skip to content

Merge branch 'main' into v16/feature/media-picker-modal-preview

602bdf1
Select commit
Loading
Failed to load commit list.
Merged

Media Picker Modal File Previews #19335

Merge branch 'main' into v16/feature/media-picker-modal-preview
602bdf1
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed May 16, 2025 in 40s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Enforce advisory code health rules (2 files with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
image-cropper-editor-modal.element.ts 1 advisory rule 10.00 → 9.69 Suppress
file-upload-preview.element.ts 1 advisory rule 10.00 → 9.69 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method file-upload-preview.element.ts: UmbFileUploadPreviewElement.setPreviewAlias
  • Complex Method image-cropper-editor-modal.element.ts: UmbImageCropperEditorModalElement.getSrc

Annotations

Check warning on line 109 in src/Umbraco.Web.UI.Client/src/packages/media/media/modals/image-cropper-editor/image-cropper-editor-modal.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbImageCropperEditorModalElement.getSrc has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 79 in src/Umbraco.Web.UI.Client/src/packages/media/media/components/input-upload-field/file-upload-preview.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

UmbFileUploadPreviewElement.setPreviewAlias has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.