Invalidate external login session on removal of provider (13) #19273
CodeScene PR Check
Quality Gate Failed
Gates Failed
(1 file with Constructor Over-Injection)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| BackOfficeExternalLoginProviders.cs | 1 advisory rule | 10.00 → 9.69 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Constructor Over-Injection BackOfficeExternalLoginProviders.cs: BackOfficeExternalLoginProviders
✅ Improving Code Health:
- Primitive Obsession UserService.cs
- Primitive Obsession UserRepository.cs
Annotations
Check warning on line 48 in src/Umbraco.Web.BackOffice/Security/BackOfficeExternalLoginProviders.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
BackOfficeExternalLoginProviders has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 1 in src/Umbraco.Core/Services/UserService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 68.00% to 67.46%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 53.52% to 53.42%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.