Skip to content

Member Type Root Collection View / Workspace#19271

Merged
madsrasmussen merged 3 commits intomainfrom
v16/feature/member-type-root-collection-view
May 8, 2025
Merged

Member Type Root Collection View / Workspace#19271
madsrasmussen merged 3 commits intomainfrom
v16/feature/member-type-root-collection-view

Conversation

@leekelleher
Copy link
Member

Description

Adds a workspace/collection-view for the root of the Member Types.

Screenshot 2025-05-07 192820

Copilot AI review requested due to automatic review settings May 7, 2025 18:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new workspace/collection view for Member Type roots by adding a new collection for tree item children, along with the repository, manifests, and related integrations.

  • Adds a new type and repository for handling member type tree item children collections.
  • Defines new manifests for collection actions, repositories, and workspace views.
  • Updates the member-type entity and index files to integrate the new workspace.

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/tree-item-children/collection/types.ts Adds a new interface with a parent property for filtering.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/tree-item-children/collection/repository/member-type-tree-item-children-collection.repository.ts Implements a repository using the entity context to determine which tree request method to use.
src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/manifests.ts Updates workspace view configuration to use the new collection.
src/Umbraco.Web.UI.Client/src/packages/core/collection/action/create/collection-create-action.element.ts Adjusts the collection create action button with new href and target attributes.
Other manifest and constants files Registers and exports new aliases for the member type tree item children collection and workspace.
Comments suppressed due to low confidence (1)

src/Umbraco.Web.UI.Client/src/packages/core/collection/action/create/collection-create-action.element.ts:101

  • [nitpick] Ensure that adding the 'href' and 'target' attributes to the uui-button integrates correctly with the navigation behavior expected by the onClick handler. It might be beneficial to review if these changes align with the component's design for handling link navigation.
href=${ifDefined(href)}

Copy link
Member

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. Great 💯

@madsrasmussen madsrasmussen merged commit 712cbe8 into main May 8, 2025
28 checks passed
@madsrasmussen madsrasmussen deleted the v16/feature/member-type-root-collection-view branch May 8, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants