Member Type Root Collection View / Workspace#19271
Merged
madsrasmussen merged 3 commits intomainfrom May 8, 2025
Merged
Conversation
in 'umb-collection-create-action-button' element.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new workspace/collection view for Member Type roots by adding a new collection for tree item children, along with the repository, manifests, and related integrations.
- Adds a new type and repository for handling member type tree item children collections.
- Defines new manifests for collection actions, repositories, and workspace views.
- Updates the member-type entity and index files to integrate the new workspace.
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/tree-item-children/collection/types.ts | Adds a new interface with a parent property for filtering. |
| src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/tree-item-children/collection/repository/member-type-tree-item-children-collection.repository.ts | Implements a repository using the entity context to determine which tree request method to use. |
| src/Umbraco.Web.UI.Client/src/packages/members/member-type/tree/manifests.ts | Updates workspace view configuration to use the new collection. |
| src/Umbraco.Web.UI.Client/src/packages/core/collection/action/create/collection-create-action.element.ts | Adjusts the collection create action button with new href and target attributes. |
| Other manifest and constants files | Registers and exports new aliases for the member type tree item children collection and workspace. |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/collection/action/create/collection-create-action.element.ts:101
- [nitpick] Ensure that adding the 'href' and 'target' attributes to the uui-button integrates correctly with the navigation behavior expected by the onClick handler. It might be beneficial to review if these changes align with the component's design for handling link navigation.
href=${ifDefined(href)}
...-item-children/collection/repository/member-type-tree-item-children-collection.repository.ts
Show resolved
Hide resolved
madsrasmussen
approved these changes
May 8, 2025
Member
madsrasmussen
left a comment
There was a problem hiding this comment.
Looks good and works as expected. Great 💯
This was referenced Jul 28, 2025
This was referenced Aug 26, 2025
This was referenced Sep 8, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a workspace/collection-view for the root of the Member Types.