Skip to content

V15/fix/18595 #18925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nielslyngsoe merged 2 commits into from
Apr 7, 2025
Merged

V15/fix/18595 #18925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a5823
fix for #18595
Welander1994 Apr 3, 2025
9596c96
updates the en.ts
Welander1994 Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Umbraco.Web.UI.Client/src/assets/lang/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1592,6 +1592,7 @@ export default {
'\n If mandatory, the child template must contain a <code>@section</code> definition, otherwise an error is shown.\n ',
queryBuilder: 'Query builder',
itemsReturned: 'items returned, in',
publishedItemsReturned: 'Currently %0% published items returned, in %1% ms',
iWant: 'I want',
allContent: 'all content',
contentOfType: 'content of type "%0%"',
Expand Down
4 changes: 1 addition & 3 deletions ...ent/src/packages/templating/templates/modals/query-builder/query-builder-modal.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,9 +243,7 @@
</div>
<div class="row query-results">
<span id="results-count">
${this._templateQuery?.resultCount ?? 0}
<umb-localize key="template_itemsReturned">items returned, in</umb-localize>
${this._templateQuery?.executionTime ?? 0} ms
<umb-localize key="template_publishedItemsReturned" .args=${[this._templateQuery?.resultCount ?? 0, this._templateQuery?.executionTime ?? 0]}>items returned, in</umb-localize>

Check notice on line 246 in src/Umbraco.Web.UI.Client/src/packages/templating/templates/modals/query-builder/query-builder-modal.element.ts

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev)

✅ Getting better: Large Method 

UmbTemplateQueryBuilderModalElement.render decreases from 89 to 87 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
</span>
${this._templateQuery?.sampleResults.map(
(sample) => html`<span><umb-icon name=${sample.icon}></umb-icon>${sample.name}</span>`,
Expand Down
Loading