V15: Upload Field should use a better file preview#18899
Merged
iOvergaard merged 1 commit intov15/devfrom Apr 1, 2025
Merged
Conversation
…he component to use `<uui-card-media />` instead
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the file preview in the upload field component by removing the duplicated server URL and replacing the previous preview with the component.
- Removed server URL concatenation and obsolete state properties
- Introduced private getters for label and file extension to drive the new card media component
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/media/media/components/input-upload-field/preview/input-upload-field-file.element.ts:20
- The fallback logic in the getter for #label may yield an empty string when this.path is defined but does not contain a valid file name, potentially causing a missing label in the preview. Consider adding explicit handling for such edge cases.
return this.path.split('/').pop() ?? `(${this.localize.term('general_loading')}...)`;
...ackages/media/media/components/input-upload-field/preview/input-upload-field-file.element.ts
Show resolved
Hide resolved
leekelleher
approved these changes
Apr 1, 2025
This was referenced Sep 28, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the serverUrl was shown twice and changes the component to use
<uui-card-media />instead.Benefits include:
Screenshots
🔴 BEFORE

✅ AFTER
