V15: Revert "Fix: RTE markup props not up to date issue"#18879
Merged
iOvergaard merged 4 commits intorelease/15.3.1from Mar 31, 2025
Merged
V15: Revert "Fix: RTE markup props not up to date issue"#18879iOvergaard merged 4 commits intorelease/15.3.1from
iOvergaard merged 4 commits intorelease/15.3.1from
Conversation
This reverts commit 347e898.
cherry-picked from c03a8af Co-authored-by: Niels Lyngsø <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous fix to address a regression affecting RTE markup props. The changes restore previous behavior in multiple components by reintroducing the use of the original markup values.
- Reverts the change in the tinyMCE property editor component to use an internal _latestMarkup variable.
- Removes an equality check from the TinyMCE input component’s value setter.
- Replaces comparisons of _markup with _latestMarkup in the RTE base component.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts | Reverts to storing and applying the latest markup using _latestMarkup |
| src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts | Removes an early return check in the value setter |
| src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts | Updates comparisons to use _latestMarkup and initializes new properties |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts:42
- [nitpick] The inline comment appears ambiguous regarding whether to retrieve the markup via doc.body.innerHTML or another method. Consider clarifying or removing the comment to prevent confusion.
// maybe in this way doc.body.innerHTML;
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts:63
- Removing the equality check may lead to unnecessary updates if the new value is the same as the current one. Consider reintroducing the check if its purpose was to prevent redundant processing.
if (newValue === this.value) return;
AndyButland
approved these changes
Mar 31, 2025
Contributor
AndyButland
left a comment
There was a problem hiding this comment.
Can confirm that having checked out this branch, rebuilt and run I no longer see the issue.
leekelleher
added a commit
to leekelleher/umbraco-tinymce
that referenced
this pull request
May 13, 2025
Applied fixes from umbraco/Umbraco-CMS#18879
This was referenced Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression introduced by #18430 and reported in #18795
Fixes #18795