V15: Revert "Fix: RTE markup props not up to date issue"#18878
Closed
iOvergaard wants to merge 2 commits intov15/devfrom
Closed
V15: Revert "Fix: RTE markup props not up to date issue"#18878iOvergaard wants to merge 2 commits intov15/devfrom
iOvergaard wants to merge 2 commits intov15/devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes made to fix an issue with RTE markup update behavior that introduced a regression. The changes revert modifications to how the markup state is tracked and updated across the TinyMCE and RTE components.
- Revert switching from super.value to this.value in the TinyMCE property editor.
- Remove the equality check in the TinyMCE input component set value.
- Adjust RTE base element logic to consistently use the _latestMarkup property.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/tiny-mce/property-editors/tiny-mce/property-editor-ui-tiny-mce.element.ts | Reverts value update to use this.value with _latestMarkup and adds clarifying comments. |
| src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts | Removes an equality check for newValue to permit unconditional update propagation. |
| src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts | Replaces comparisons and assignments to rely on _latestMarkup instead of _markup to maintain consistency. |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/tiny-mce/components/input-tiny-mce/input-tiny-mce.element.ts:63
- Removing the equality check may lead to unnecessary updates; please double-check that this change aligns with the intended update logic.
if (newValue === this.value) return;
src/Umbraco.Web.UI.Client/src/packages/rte/components/rte-base.element.ts:63
- Confirm that switching from comparing _markup to _latestMarkup is consistent with overall state management and does not introduce side effects.
if (this._latestMarkup !== super.value.markup) {
Comment on lines
+42
to
+43
| // maybe in this way doc.body.innerHTML; | ||
|
|
There was a problem hiding this comment.
[nitpick] The comment is ambiguous and may cause confusion; consider clarifying its intent or removing it if no longer needed.
Suggested change
| // maybe in this way doc.body.innerHTML; | |
| // TODO: Consider using doc.body.innerHTML to get the content of the editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression introduced by #18430 and reported in #18795
Fixes #18795