Skip to content

hotfix: context provider should not destroy instance #18864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madsrasmussen merged 2 commits into from
Mar 31, 2025
Merged

hotfix: context provider should not destroy instance #18864

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d6b52
do not destroy instance
nielslyngsoe Mar 28, 2025
2cbc19b
Update src/Umbraco.Web.UI.Client/src/libs/context-api/provide/context…
nielslyngsoe Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Umbraco.Web.UI.Client/src/libs/context-api/provide/context-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ export class UmbContextProvider<BaseType = unknown, ResultType extends BaseType
// Note we are not removing the event listener in the hostDisconnected, therefor we do it here [NL].
this.#eventTarget?.removeEventListener(UMB_CONTEXT_REQUEST_EVENT_TYPE, this.#handleContextRequest);
this.#eventTarget?.removeEventListener(UMB_DEBUG_CONTEXT_EVENT_TYPE, this.#handleDebugContextRequest);
// We want to call a destroy method on the instance, if it has one.
(this.#instance as any)?.destroy?.();
// We do not want to call a destroy method on the instance, cause maybe it should be re-provided later on. [NL]
Comment thread
nielslyngsoe marked this conversation as resolved.
Outdated
this.#instance = undefined;
(this.#eventTarget as unknown) = undefined;
}
Expand Down