Skip to content

Tiptap RTE: Character Map modal + toolbar item#18577

Merged
iOvergaard merged 6 commits intov15/devfrom
v15/feature/tiptap-ext-charmap
Mar 10, 2025
Merged

Tiptap RTE: Character Map modal + toolbar item#18577
iOvergaard merged 6 commits intov15/devfrom
v15/feature/tiptap-ext-charmap

Conversation

@leekelleher
Copy link
Member

Description

Adds the Character Map modal + toolbar button to Tiptap RTE, for inserting special characters into the RTE.

Another step towards feature parity with TinyMCE RTE.

Note

The Character Map data has been adapted from the TinyMCE codebase, (v6.8.5, licensed under MIT).

How to test?

If using the mock data, then go to the "All RTEs" page and see how it works. If using the server, then configure the Tiptap RTE to add the "Character Map" toolbar button, then try it out on a document.

@leekelleher leekelleher marked this pull request as draft March 5, 2025 14:28
@leekelleher leekelleher marked this pull request as ready for review March 5, 2025 14:56
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there is a merge conflict. Have also added a comment about clearing up something around the new modal:

…-ext-charmap

# Conflicts:
#	src/Umbraco.Web.UI.Client/src/packages/tiptap/property-editors/tiptap/contexts/tiptap-toolbar-configuration.context.ts
@leekelleher leekelleher requested a review from iOvergaard March 10, 2025 11:01
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and failing e2e test does not seem to be related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants