Merged
Conversation
madsrasmussen
approved these changes
Feb 25, 2025
Member
madsrasmussen
left a comment
madsrasmussen
left a comment
There was a problem hiding this comment.
Changes looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18431
Does so by making sure the current data respects the order from the persisted data.
This both fixes the case represented in the issue, but also ensures a similar issue that happens with Property Value Presets.
The problem is that we cannot in general be indifferent about array orders in our difference comparison, but in the case of Content Values and Content Variants we can and therefor we can sort them to be like the persisted.
The reason why we go with the persisted, is because persisted is set directly to the version we get back from the server, keeping the order the server insists on. meaning once we got a persisted version we can adjust our to it and avoid differences on values or variant sort orders.