add overflow:visible to allow the workspace action menu to be highlighted#18391
add overflow:visible to allow the workspace action menu to be highlighted#18391mikecp merged 3 commits intoumbraco:contribfrom
Conversation
|
Hi there @manutdkid77, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
…hted when tabbed into
36b8088 to
d8e6c79
Compare
|
Hi @manutdkid77 ! Thanks for your PR to fix #16208, where the save/publish workspace action menu is not highlighted in Firefox. One of the Core Collaborators team will review this as soon as possible. Best wishes Emma |
|
Hello @manutdkid77 , Thanks a lot for providing this fix! And sorry that it took us this while to have a look at it 😬 Cheers! |
Description
On Mozilla Firefox, the
uui-popover-containerelement would inherit a style ofoverflow:clip, this would hide the highlight of the Save/Publish menu on Firefox.Setting
overflow:visibletouui-popover-containerallows the highlight of this element to be visible when tabbed into on Firefox browsers.This fixes #16208