Skip to content

add overflow:visible to allow the workspace action menu to be highlighted#18391

Merged
mikecp merged 3 commits intoumbraco:contribfrom
manutdkid77:temp/16208
May 1, 2025
Merged

add overflow:visible to allow the workspace action menu to be highlighted#18391
mikecp merged 3 commits intoumbraco:contribfrom
manutdkid77:temp/16208

Conversation

@manutdkid77
Copy link
Contributor

Description

On Mozilla Firefox, the uui-popover-container element would inherit a style of overflow:clip, this would hide the highlight of the Save/Publish menu on Firefox.

Setting overflow:visible to uui-popover-container allows the highlight of this element to be visible when tabbed into on Firefox browsers.

This fixes #16208

Debugging

Final Result

@github-actions
Copy link

github-actions bot commented Feb 20, 2025

Hi there @manutdkid77, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Collaborator

Hi @manutdkid77 !

Thanks for your PR to fix #16208, where the save/publish workspace action menu is not highlighted in Firefox.

One of the Core Collaborators team will review this as soon as possible.

Best wishes

Emma

@mikecp mikecp self-assigned this Apr 28, 2025
@mikecp
Copy link
Contributor

mikecp commented May 1, 2025

Hello @manutdkid77 ,

Thanks a lot for providing this fix! And sorry that it took us this while to have a look at it 😬
I have checked your update and it works as expected, so let's merge your PR now and improve accessibility in Firefox ! 😁

Cheers!

@mikecp mikecp merged commit abf0689 into umbraco:contrib May 1, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

V14-RC2: a11y: Save & Publish menu not highlighting when tabbed/focused

3 participants