Skip to content

Ported changes from Umbraco 13 around not throwing exceptions with identity IDs that can't be parsed to an integer or GUID#18389

Merged
nikolajlauridsen merged 2 commits intov15/devfrom
v15/bugfix/prevent-exception-on-find-member-with-external-id
Feb 21, 2025
Merged

Ported changes from Umbraco 13 around not throwing exceptions with identity IDs that can't be parsed to an integer or GUID#18389
nikolajlauridsen merged 2 commits intov15/devfrom
v15/bugfix/prevent-exception-on-find-member-with-external-id

Conversation

@AndyButland
Copy link
Contributor

@AndyButland AndyButland commented Feb 19, 2025

This PR ports over the updates made in:

The were resolving reports of issues with external login providers where we would have an identity id that wasn't an integer or GUID. These would fail in conversion in the attempts to find a local user matching those IDs.

Given the rework in this area these didn't merge up from 13, so I'm re-implementing them here.

I've also reverted back the changes to UmbracoUserStore.UserIdToInt that came through in the merge, but aren't necessary as the method in 15 is obsolete.

To Test:

  • I'd suggest that given this is really an addendum to the merge from 13, visual inspection will suffice.

@AndyButland AndyButland requested review from Migaroez and nikolajlauridsen and removed request for Migaroez February 19, 2025 14:45
@nikolajlauridsen nikolajlauridsen merged commit c5c64f2 into v15/dev Feb 21, 2025
21 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v15/bugfix/prevent-exception-on-find-member-with-external-id branch February 21, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants