Ported changes from Umbraco 13 around not throwing exceptions with identity IDs that can't be parsed to an integer or GUID#18389
Merged
nikolajlauridsen merged 2 commits intov15/devfrom Feb 21, 2025
Conversation
…entity IDs that can't be parsed to an integer or GUID.
nikolajlauridsen
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports over the updates made in:
The were resolving reports of issues with external login providers where we would have an identity id that wasn't an integer or GUID. These would fail in conversion in the attempts to find a local user matching those IDs.
Given the rework in this area these didn't merge up from 13, so I'm re-implementing them here.
I've also reverted back the changes to
UmbracoUserStore.UserIdToIntthat came through in the merge, but aren't necessary as the method in 15 is obsolete.To Test: