V15: Update Backoffice NPM dependencies

.github/workflows/test-backoffice.yml

@@ -43,6 +43,8 @@ jobs:
       - name: Check for circular dependencies
         run: node devops/circular/index.js src
       - run: npm run lint:errors
+      - run: npm run generate:tsconfig
+      - run: npm run generate:icons
       - run: npm run build:for:cms
       - run: npm run check:paths
       - run: npm run generate:jsonschema:dist

src/Umbraco.Web.UI.Client/.gitignore

@@ -18,6 +18,7 @@ dist-ssr
 
 ## testing
 coverage/
+utils/all-umb-consts/
 
 # Editor directories and files
 .vscode/*

src/Umbraco.Web.UI.Client/devops/icons/index.js

@@ -1,6 +1,7 @@
 import { readFileSync, writeFile, mkdir, rmSync } from 'fs';
 import * as globModule from 'tiny-glob';
 import * as pathModule from 'path';
+import { optimize } from 'svgo';
 
 const path = pathModule.default;
 const getDirName = path.dirname;
@@ -14,6 +15,10 @@
 const lucideSvgDirectory = 'node_modules/lucide-static/icons';
 const simpleIconsSvgDirectory = 'node_modules/simple-icons/icons';
 
+const IS_GITHUB_ACTIONS = process.env.GITHUB_ACTIONS === 'true';
+
+const errors = [];
+
 const run = async () => {
 	// Empty output directory:
 	rmSync(iconsOutputDirectory, { recursive: true });
@@ -55,62 +60,65 @@
 
 				icons.push(icon);
 			} catch (e) {
+				errors.push(`[Lucide] Could not load file: '${path}'`);
 				console.log(`[Lucide] Could not load file: '${path}'`);
 			}
 		}
 	});
 
 	// SimpleIcons:
 	fileJSON.simpleIcons.forEach((iconDef) => {
 		if (iconDef.file && iconDef.name) {
 			const path = simpleIconsSvgDirectory + '/' + iconDef.file;
 
 			try {
 				const rawData = readFileSync(path);
 				let svg = rawData.toString();
 				const iconFileName = iconDef.name;
 
 				// SimpleIcons need to use fill="currentColor"
 				const pattern = /fill=/g;
 				if (!pattern.test(svg)) {
 					svg = svg.replace(/<path/g, '<path fill="currentColor"');
 				}
 
 				const icon = {
 					name: iconDef.name,
 					legacy: iconDef.legacy,
 					fileName: iconFileName,
 					svg,
 					output: `${iconsOutputDirectory}/${iconFileName}.ts`,
 				};
 
 				icons.push(icon);
 			} catch (e) {
+				errors.push(`[SimpleIcons] Could not load file: '${path}'`);
 				console.log(`[SimpleIcons] Could not load file: '${path}'`);
 			}
 		}
 	});
 
 	// Umbraco:
 	fileJSON.umbraco.forEach((iconDef) => {
 		if (iconDef.file && iconDef.name) {
 			const path = umbracoSvgDirectory + '/' + iconDef.file;
 
 			try {
 				const rawData = readFileSync(path);
 				const svg = rawData.toString();
 				const iconFileName = iconDef.name;
 
 				const icon = {
 					name: iconDef.name,
 					legacy: iconDef.legacy,
 					fileName: iconFileName,
 					svg,
 					output: `${iconsOutputDirectory}/${iconFileName}.ts`,
 				};
 
 				icons.push(icon);
 			} catch (e) {
+				errors.push(`[Umbraco] Could not load file: '${path}'`);
 				console.log(`[Umbraco] Could not load file: '${path}'`);
 			}
 		}
@@ -157,7 +165,9 @@
 
 const writeIconsToDisk = (icons) => {
 	icons.forEach((icon) => {
-		const content = 'export default `' + icon.svg + '`;';
+		const optimizedResult = optimize(icon.svg);
+
+		const content = 'export default `' + optimizedResult.data + '`;';
 
 		writeFileWithDir(icon.output, content, (err) => {
 			if (err) {
@@ -199,10 +209,23 @@
 
 const writeFileWithDir = (path, contents, cb) => {
 	mkdir(getDirName(path), { recursive: true }, function (err) {
-		if (err) return cb(err);
+		if (err) {
+			errors.push(err);
+			return cb(err);
+		}
 
 		writeFile(path, contents, cb);
 	});
 };
 
-run();
+await run();
+
+if (errors.length > 0) {
+	if (IS_GITHUB_ACTIONS) {
+		const msg = errors.join('\n');
+		console.log(`::error title=Failed to generate all icons::${msg}`);
+		process.exit(1);
+	} else {
+		console.error('Failed to generate all icons, please see the error log');
+	}
+}