Feature: Use uui invalid color#18273
Merged
nielslyngsoe merged 19 commits intov15/devfrom Apr 9, 2025
Merged
Conversation
# Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts
Contributor
Member
Author
|
I just had to test it does work here, maybe installing latest npm dependencies was missing when Welander tested. It does thought not inherit the yellow color scheme in the Block Workspace. But there validation issues are also preventing the user from submitting, so for now that is okay IMO. then we will correct that part of the experience later when we know if we like the user to be allowed to close modals with issues. |
src/Umbraco.Web.UI.Client/src/packages/core/content/workspace/content-detail-workspace-base.ts
Outdated
Show resolved
Hide resolved
Member
Member
Member
Author
|
@madsrasmussen I have corrected your suggestions. Though not the disabled save button, as it is not possible to save without a name. |
madsrasmussen
approved these changes
Apr 9, 2025
This was referenced Apr 9, 2025
This was referenced Sep 28, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #17089
Fixes #18416
This PR. runs validation + server validation when saving Documents, without preventing save from happening.
Therefor this adjusts the validation feedback color for Saving vs. Publishing. So its not danger-red when Saving, just yellow.