Redirect to the published URL when exiting preview#18114
Merged
AndyButland merged 2 commits intov13/devfrom Jan 24, 2025
Merged
Redirect to the published URL when exiting preview#18114AndyButland merged 2 commits intov13/devfrom
AndyButland merged 2 commits intov13/devfrom
Conversation
AndyButland
approved these changes
Jan 24, 2025
Contributor
AndyButland
left a comment
There was a problem hiding this comment.
Looks logical to me and works as described 💪
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #7922
Description
Following the discussion on #7922, when exiting document previews we should not blindly redirect to the "by ID" route. Instead we should:
This PR implements that 👍
Testing this PR - with URL providers
When exiting preview for a given document, verify that:
Test this both for culture variant and invariant content.
Testing this PR - without URL providers
Remove all URL providers with this code:
When exiting preview for a given document, verify that:
Umbraco:WebRouting:DisableFindContentByIdPathset tofalse, the client is redirected to the "by ID" route (as-is today).Umbraco:WebRouting:DisableFindContentByIdPathset totrue, the client is redirected to the site root (in lieu of better options).