Avoid an exception on sign out when the principal is populated from an incomplete external login #18078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

nikolajlauridsen merged 2 commits into v13/dev from v13/bugfix/dont-throw-on-signout-after-issue-in-external-login

Feb 10, 2025

This check has been archived and is scheduled for deletion. Learn more about checks retention

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev) succeeded Jan 22, 2025 in 37s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.14 (5.43 -> 5.57)

Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

Code Duplication BackOfficeUserStore.cs

Annotations

Check notice on line 1 in src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs

codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

✅ Getting better: Code Duplication

reduced similar code in: FindByNameAsync,FindUserAsync. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check notice on line 1 in src/Umbraco.Infrastructure/Security/BackOfficeUserStore.cs

codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 5.04 to 5.08, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

View more details on CodeScene Delta Analysis