Skip to content

Fix: only fire event when instance is available (issue 17847) #17987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Migaroez merged 2 commits into from
Jan 15, 2025
Merged

Fix: only fire event when instance is available (issue 17847) #17987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2db9b
only fire event when instance is available
nielslyngsoe Jan 15, 2025
a318de4
avoid js issue when no markup
nielslyngsoe Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
(function () {

Check notice on line 1 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/rte.component.js

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 5.00 to 5.03, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
"use strict";

/**
Expand Down Expand Up @@ -256,7 +256,7 @@
toolbar: editorConfig.toolbar,
model: vm.model,
getValue: function () {
return vm.model.value.markup;
return vm.model.value.markup ?? "";
},
setValue: function (newVal) {
vm.model.value.markup = newVal;
Expand Down Expand Up @@ -348,7 +348,9 @@
// But I'm not sure it's needed, as this does not trigger the RTE
if(modelObject) {
modelObject.update(vm.model.value.blocks, $scope);
vm.tinyMceEditor.fire('updateBlocks');
if (vm.tinyMceEditor) {
vm.tinyMceEditor.fire('updateBlocks');
}
onLoaded();
}
}
Expand Down
Loading