Skip to content

Do not show "Save and preview" by default#17986

Merged
AndyButland merged 1 commit intorelease/13.6from
v13/fix/16854-hide-save-and-preview-by-default
Jan 15, 2025
Merged

Do not show "Save and preview" by default#17986
AndyButland merged 1 commit intorelease/13.6from
v13/fix/16854-hide-save-and-preview-by-default

Conversation

@kjac
Copy link
Contributor

@kjac kjac commented Jan 15, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #16854

Description

Even if a user is not allowed to save or send to publish, they will still see the "Save and preview" button. Fortunately it doesn't work, but it's still wrong.

This PR fixes it.

Testing this PR

⚠️ Remember to rebuild the client before testing ⚠️

  1. Create a user with only "Browse" permissions to content.
  2. Login with this user and verify that no buttons are shown for content.
  3. Verify that the "Save and publish" button still works for users with content save permission.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested and can confirm this resolves the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants