V15: Adds validation to all entity workspaces#17980
Merged
leekelleher merged 25 commits intov15/devfrom Jan 14, 2025
Merged
Conversation
…se` to use for named entities
…le to save some code
…all workspaces with a name follows the same interface this allows the workspace to act as a UmbNamableWorkspace
…for the name field
… by their base class
leekelleher
approved these changes
Jan 14, 2025
Member
leekelleher
left a comment
There was a problem hiding this comment.
Tested it out on the following areas, (drumroll please 🥁 )... Data Types, Data Type Folders, Dictionary (Translations), Document Blueprint Folder, Document Type Folders, Languages, Media Type Folders, Member Groups, Package Builder, Partial Views, Partial View Folders, Relation Types (read-only), Stylesheets, Stylesheet Folders, Scripts, Script Folders, Templates and Users... and the name validation works as expected! 🙌🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is part 2 of 2 that fixes #17514 to add validation to workspaces, particularly the name field.
Warning
Make sure pull request #17959 has been merged before merging this one (it contains some of the same changes).
Changes
<umb-workspace-header-name-editable />element which comes with validation out of the box.<umb-input-with-alias />element, which also comes with validation.How to test
This is most useful to test for: templates, partial views, scripts, stylesheets, data types, and users.