Skip to content

V13: Show validation error, when saving invalid media #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zeegaan merged 4 commits into from
Jan 14, 2025
Merged

V13: Show validation error, when saving invalid media #17961

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4b6acf
Don't save invalid media
Zeegaan Jan 13, 2025
6758d61
Revert "Don't save invalid media"
Zeegaan Jan 14, 2025
5339430
Still allow save, but show validation error, not popup error
Zeegaan Jan 14, 2025
ba91fca
Add clarifying comment
Zeegaan Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,8 @@ public async Task<IActionResult> PostMove(MoveOrCopy move)
null); // media are all invariant

// we will continue to save if model state is invalid, however we cannot save if critical data is missing.
// TODO: Allowing media to be saved when it is invalid is odd - media doesn't have a publish phase so suddenly invalid data is allowed to be 'live'
// this is a design decision, to continue to be able to save invalid content
// as you can do the same with documents. This will be removed in a future version.
if (!ModelState.IsValid)
{
// check for critical data validation issues, we can't continue saving if this data is invalid
Expand All @@ -495,10 +496,10 @@ public async Task<IActionResult> PostMove(MoveOrCopy move)
// return the updated model
MediaItemDisplay? display = _umbracoMapper.Map<MediaItemDisplay>(contentItem.PersistedContent);

// lastly, if it is not valid, add the model state to the outgoing object and throw a 403
// lastly, if it is not valid, add the model state to the outgoing object.
if (!ModelState.IsValid)
{
return ValidationProblem(display, ModelState, StatusCodes.Status403Forbidden);
return ValidationProblem(display, ModelState);
}

// put the correct msgs in
Expand Down