Skip to content

Hotfix: Browser navigation between Documents #17783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOvergaard merged 2 commits into from
Dec 11, 2024
Merged

Hotfix: Browser navigation between Documents #17783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b22fc83
use replaceState
nielslyngsoe Dec 11, 2024
985582f
Merge branch 'release/15.1' into v15/hotfix/17650
nielslyngsoe Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...UI.Client/src/packages/core/workspace/controllers/workspace-is-new-redirect.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export class UmbWorkspaceIsNewRedirectController extends UmbControllerBase {
id: unique,
});
this.destroy();
window.history.pushState({}, '', newPath);
window.history.replaceState({}, '', newPath);
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...UI.Client/src/packages/documents/documents/workspace/document-workspace-editor.element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ export class UmbDocumentWorkspaceEditorElement extends UmbLitElement {

if (!route) {
// TODO: Notice: here is a specific index used for fallback, this could be made more solid [NL]
history.pushState({}, '', `${this.#workspaceRoute}/${routes[routes.length - 3].path}`);
history.replaceState({}, '', `${this.#workspaceRoute}/${routes[routes.length - 3].path}`);
return;
}

history.pushState({}, '', `${this.#workspaceRoute}/${route?.path}`);
history.replaceState({}, '', `${this.#workspaceRoute}/${route?.path}`);
},
});
}
Expand Down