V15: TinyMce triggers navigation when clicking links#17781
Merged
nielslyngsoe merged 2 commits intorelease/15.1from Dec 11, 2024
Merged
V15: TinyMce triggers navigation when clicking links#17781nielslyngsoe merged 2 commits intorelease/15.1from
nielslyngsoe merged 2 commits intorelease/15.1from
Conversation
Tinymce inserts links using the a-tag, which is triggering our navigation because we cannot control tinymce's rendering. We can however control which links we trigger on the for the 'click' event by using `composedPath()` and ensuring that we are inside one of the block entry elements.
nielslyngsoe
approved these changes
Dec 11, 2024
Member
nielslyngsoe
left a comment
nielslyngsoe
left a comment
There was a problem hiding this comment.
Work really well, the expected result both for a tags and for Blocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17748
Tinymce inserts links using the a-tag, which is triggering our navigation because we cannot control tinymce's rendering. We can however control which links we trigger on the for the 'click' event by using
composedPath()and ensuring that we are inside one of the block entry elements.