V15 RC: Tiptap should only target valid block elements#17712
Merged
nielslyngsoe merged 4 commits intorelease/15.1from Dec 5, 2024
Merged
V15 RC: Tiptap should only target valid block elements#17712nielslyngsoe merged 4 commits intorelease/15.1from
nielslyngsoe merged 4 commits intorelease/15.1from
Conversation
This is to say we should remove any invalid block elements to clean up the DOM. A block element is considered invalid if it does not have the `data-content-key` attribute.
this fixes a potential issue with link creations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: make sure we only target valid blocks
This is to say we should remove any invalid block elements to clean up the DOM. A block element is considered invalid if it does not have the
data-content-keyattribute.