Hotfix: Do not set icon color if item is active#17703
Merged
iOvergaard merged 1 commit intorelease/15.1from Dec 4, 2024
Merged
Hotfix: Do not set icon color if item is active#17703iOvergaard merged 1 commit intorelease/15.1from
iOvergaard merged 1 commit intorelease/15.1from
Conversation
iOvergaard
approved these changes
Dec 4, 2024
bergmania
reviewed
Dec 4, 2024
|
|
||
| override renderIconContainer() { | ||
| const icon = this.item?.documentType.icon; | ||
| const iconWithoutColor = icon?.split(' ')[0]; |
Member
There was a problem hiding this comment.
The icon?.split(' ')[0]; logic is shared, should it be a method on the base class that can handle the logic?
Member
Author
There was a problem hiding this comment.
I would prefer if this got moved all the way to the server. If that is not possible, we should map the data when we receive it. Instead of a string with both, we should have name and color in separate props. I think we will need this in more cases.
Member
There was a problem hiding this comment.
To me it seems like a UI concern that a picked icon and colour has to change, but I can shared your idea with the rest of the team
Member
There was a problem hiding this comment.
Otherwise you only talk about splitting colour and icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #16882
The fix has been applied to tree items in general, media, and document tree items.