Conversation
|
Hi there @OwainJ, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Thanks a lot @OwainJ for your PR and for keeping the cy.xml file up to date 👍 |
|
Hi again @OwainJ , Woops I went a little too fast and forgot that the place where the localization files are stored, has changed since V14 😅 Most of the translations have in fact moved to client-side json-formatted files that you can find in the Umbraco.CMS.Backoffice repositoy, under You can find more details about that in the documentation if you wish: https://docs.umbraco.com/umbraco-cms/extending/language-files All this to say that it would be super great if you could copy over the new keys you created in this PR to a new PR updating the new cy-gb.ts localization file in the Umbraco.CMS.Backoffice repository 😁 Thank you so much!! 👍 |
Ah ha! I didn't realize that, I was thinking that there where a lot less keys in there than I remember haha 😆 |
|
Hi there @OwainJ! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |

cylang file to include missing keys found in theen_uslang file.runtimeModeCheckSuccessMessageruntimeModeCheckErrorMessagecontentSecurityPolicyCheckHeaderFoundcontentSecurityPolicyCheckHeaderNotFound