Skip to content

append 'YouTube Live' url scheme regex to Youtube embed provider class#17283

Merged
busrasengul merged 1 commit intoumbraco:contribfrom
fredelundbeck:temp/16948
Nov 7, 2024
Merged

append 'YouTube Live' url scheme regex to Youtube embed provider class#17283
busrasengul merged 1 commit intoumbraco:contribfrom
fredelundbeck:temp/16948

Conversation

@fredelundbeck
Copy link

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #16948

Description

When trying to embed a youtube live link (youtube.com/live/.*) in a rich text editor, you get an "not supported" error.
To fix this I appended a regex, that matches youtube live links, to the Youtube OEmbed provider class (Umbraco.Cms.Core.Media.EmbedProviders.Youtube).

To test it:

  1. Create a page with a rich text editor property
  2. Try to embed a link to a youtube live video e.g. https://www.youtube.com/live/jfKfPfyJRdk?si=E9dea9hKldX81B83
  3. Save the changes
  4. Observe that an error notification isn't popping up
  5. Create a view for the page doctype and render the RTE property content
  6. Observe that the embedded youtube video is rendered and can be played

@github-actions
Copy link

github-actions bot commented Oct 15, 2024

Hi there @fredelundbeck, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @fredelundbeck, thanks a lot for your pull request! Someone on the core collaborators team will review this soon 🚀

I've also noticed this is your first PR into the Umbraco repo! If you let us know your Our.Umbraco account username, we can grant you a C-Tribe badge, once your PR is merged 🥳

@nul800sebastiaan
Copy link
Member

Thanks @fredelundbeck and sorry for the delay, we'll get to it!

Just a hint: as you may know, this PR qualifies for Umbraco's Hacktoberfest participation for which you can earn rewards.
If you were to make 1 more contribution in the next few days, would be great to see your contributions qualify! You can do it.. 😉

@busrasengul
Copy link
Contributor

Hey @fredelundbeck I've reviewed your PR and all looks great to me! I could add a live youtube embed URL 🎉

I'm merging this now! If you can provide your our.umbraco.com account name/member id to me, I can also add a shiny C-Trib badge too!

@busrasengul busrasengul merged commit 7a8ba96 into umbraco:contrib Nov 7, 2024
@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @fredelundbeck!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants