append 'YouTube Live' url scheme regex to Youtube embed provider class#17283
append 'YouTube Live' url scheme regex to Youtube embed provider class#17283busrasengul merged 1 commit intoumbraco:contribfrom
Conversation
|
Hi there @fredelundbeck, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hey @fredelundbeck, thanks a lot for your pull request! Someone on the core collaborators team will review this soon 🚀 I've also noticed this is your first PR into the Umbraco repo! If you let us know your Our.Umbraco account username, we can grant you a C-Tribe badge, once your PR is merged 🥳 |
|
Thanks @fredelundbeck and sorry for the delay, we'll get to it! Just a hint: as you may know, this PR qualifies for Umbraco's Hacktoberfest participation for which you can earn rewards. |
|
Hey @fredelundbeck I've reviewed your PR and all looks great to me! I could add a live youtube embed URL 🎉 I'm merging this now! If you can provide your our.umbraco.com account name/member id to me, I can also add a shiny C-Trib badge too! |
|
Hi there @fredelundbeck! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |

Prerequisites
If there's an existing issue for this PR then this fixes #16948
Description
When trying to embed a youtube live link (youtube.com/live/.*) in a rich text editor, you get an "not supported" error.
To fix this I appended a regex, that matches youtube live links, to the Youtube OEmbed provider class (Umbraco.Cms.Core.Media.EmbedProviders.Youtube).
To test it: