v13.5 - New Swedish translation crashes Umbraco, removed duplicate areas.

[madsoulswe]

New Swedish translation crashes Umbraco

Prerequisites

LocalizedTextService.GetAreaStoredTranslations crashes on duplicate area-keys

Description

Removed duplicate areas

[github-actions]

Hi there @madsoulswe, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[madsoulswe]

"Crashes" might be the wrong word. But it crashes all valueconverters etc.

[mikecp]

HI @madsoulswe,

Thanks a lot for spotting the issue and providing the fix 👍
A member of the team will have a look at it soon!

Cheers!

[madsoulswe]

Hi @mikecp !

I included a fix for LocalizedTextService so it merges all duplicate-areas
f3583bc

I have created some basic tests for the embeded xml-files, but I found other things so it will be another PR.

• zh, zh_tw has wrong/invalid LCID.
• cy, de, sv have multiple duplicate keys.

[nul800sebastiaan]

Thanks so much for the quick PR @madsoulswe this is helpful. I've reproduced the original issue and can confirm it's gone with this PR, also tested what happens if you have duplicate keys now and as predicted the first one will be used, which is perfect.

Code looks good too, so I'll merge! Thanks again! #h5yr 👍

[jrunestone]

@nul800sebastiaan Thank you for the swift merge, appreciate it 🎉 And @madsoulswe ofc!