POC: Feat/make indexing more resiliant #16546
CodeScene PR Check
Quality Gate Failed
Gates Failed
(4 files with Missing Arguments Abstractions, Complex Method, Excess Number of Function Arguments, Constructor Over-Injection)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| IndexRebuildStatusManager.cs | 1 advisory rule | 10.00 → 9.69 | Suppress |
| ExamineManagementController.cs | 1 advisory rule | 10.00 → 9.69 | Suppress |
| ContentIndexPopulator.cs | 1 advisory rule | 8.96 → 8.68 | Suppress |
| ExamineIndexRebuilder.cs | 1 advisory rule | 8.55 → 8.52 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method ExamineIndexRebuilder.cs: RebuildIndexes
- Missing Arguments Abstractions ContentIndexPopulator.cs
- Excess Number of Function Arguments IndexRebuildStatusManager.cs: UpdatePopulatorStatus
- Constructor Over-Injection ExamineManagementController.cs: ExamineManagementController
✅ Improving Code Health:
- Overall Code Complexity ExamineIndexRebuilder.cs
Annotations
Check warning on line 1 in src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Missing Arguments Abstractions
The average number of function arguments in this module is 4.13 across 8 functions. The average arguments threshold is 4.00. The functions in this file have too many arguments, indicating a lack of encapsulation or too many responsibilities in the same functions. Avoid adding more.
Check warning on line 245 in src/Umbraco.Infrastructure/Examine/ExamineIndexRebuilder.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ Getting worse: Complex Method
RebuildIndexes increases in cyclomatic complexity from 10 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/Umbraco.Infrastructure/Examine/ExamineIndexRebuilder.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.38 to 4.22, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 91 in src/Umbraco.Infrastructure/Examine/IndexRebuildStatusManager.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Excess Number of Function Arguments
UpdatePopulatorStatus has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check warning on line 52 in src/Umbraco.Web.BackOffice/Controllers/ExamineManagementController.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)
❌ New issue: Constructor Over-Injection
ExamineManagementController has 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.