calling IContent.GetValue<DateOnly?>() on a DatePicker property results in a null value

[robertjf]

Which Umbraco version are you using?

17.2.1

Bug summary

I have a property configured as a DateOnly editor, and retrieving the value on an IContent node using GetValue<DateOnly?>() or GetValue<DateOnly>() returns null or minimum date respectively instead of the actual value:

For example, the following image shows the raw value when called using the non-Generic form of GetValue and what happens when called with the Generic form:

This also produces similar output if I attempt to retrieve the value as a DateTime as well.

Specifics

See above

Steps to reproduce

1. Create a document type with a DateOnly property editor on it
2. Create a node based on the document type and set the property to a valid value.
3. Attempt to retrieve the value using the ContentService and IContent representation of the node
4. Value will be null if calling content.GetValue<DateOnly?>()

Expected result / actual result

The actual value should be returned

[github-actions]

Hi there @robertjf!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

I think this is expected @robertjf. You are working with IContent here, not IPublishedContent, so the property value converters that convert the JSON value representing the date with it's timezone into the output DateOnly type won't be operating.

If you do want to work with IContent here, you'll need to do the deserialization yourself.

Something like this:

    var content = ContentService.GetById(Guid.Parse("ca4249ed-2b23-4337-b522-63cabe5587d1"));
    if (content is not null)
    {
        var rawValue = content.GetValue("myDateProperty");
        <div>Raw value: @rawValue</div>

        if (string.IsNullOrEmpty(rawValue?.ToString()) is false)
        {
            var dto = JsonSerializer.Deserialize<DateTimeDto>(rawValue.ToString()!);
            if (dto is not null)
            {
                <div>Parsed DateTime: @dto.Date.Date</div>
                var dateOnlyValue = DateOnly.FromDateTime(dto.Date.Date);
                <div>Parsed DateOnly Value: @dateOnlyValue</div>
            }
            else
            {
                <div>Could not parse raw value to DateTimeDto.</div>
            }
        }
    }

DateTimeDto is defined in Umbraco.Cms.Core.PropertyEditors.ValueConverters.

I'll close this, as I would say this is expected behaviour and the same that you would see with any other property editor that stores it's value as JSON, but please let me know if I've missed something.

[robertjf]

Ah, of course - thanks @AndyButland for the reminder :)